Se.Cherkasov/VVVVVV
1
0
Fork 0
mirror of https://github.com/TerryCavanagh/VVVVVV.git synced 2026-01-29 17:38:16 +03:00
Code Issues Packages Projects Releases Wiki Activity

Use const std::string& where possible in function params

Browse Source 
If it's at all possible to use `const std::string&` when passing
`std::string`s around, then we use it. This is to limit the amount of
memory usage as a result of the frequent use of `std::string`s, so the
game no longer unnecessarily copies strings when it doesn't need to.
This commit is contained in:
Misa
2021-09-06 15:41:49 -07:00
parent ff07f9c268
commit 33c5b8b7c0
10 changed files with 49 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
desktop_version/src/Editor.cpp
View File

@@ -122,7 +122,7 @@ void editorclass::gethooks(void)
}
}
void editorclass::loadhookineditor(std::string t)
void editorclass::loadhookineditor(const std::string& t)
{
//Find hook t in the scriptclass, then load it into the editor
clearscriptbuffer();
@@ -145,7 +145,7 @@ void editorclass::loadhookineditor(std::string t)
}
}
void editorclass::addhooktoscript(std::string t)
void editorclass::addhooktoscript(const std::string& t)
{
//Adds hook+the scriptbuffer to the end of the scriptclass
removehookfromscript(t);
@@ -155,7 +155,7 @@ void editorclass::addhooktoscript(std::string t)
script.customscripts.push_back(script_);
}
void editorclass::removehookfromscript(std::string t)
void editorclass::removehookfromscript(const std::string& t)
{
/* Find hook t in the scriptclass, then removes it (and any other code with it)
* When this loop reaches the end, it wraps to SIZE_MAX; SIZE_MAX + 1 is 0 */
@@ -169,7 +169,7 @@ void editorclass::removehookfromscript(std::string t)
}
}
void editorclass::removehook(std::string t)
void editorclass::removehook(const std::string& t)
{
//Check the hooklist for the hook t. If it's there, remove it from here and the script
size_t i;
@@ -184,7 +184,7 @@ void editorclass::removehook(std::string t)
}
}
void editorclass::addhook(std::string t)
void editorclass::addhook(const std::string& t)
{
//Add an empty function to the list in both editor and script
removehook(t);
@@ -192,7 +192,7 @@ void editorclass::addhook(std::string t)
addhooktoscript(t);
}
bool editorclass::checkhook(std::string t)
bool editorclass::checkhook(const std::string& t)
{
//returns true if hook t already is in the list
for(size_t i=0; i<hooklist.size(); i++)