Use const std::string& where possible in function params

If it's at all possible to use `const std::string&` when passing
`std::string`s around, then we use it. This is to limit the amount of
memory usage as a result of the frequent use of `std::string`s, so the
game no longer unnecessarily copies strings when it doesn't need to.
This commit is contained in:
Misa
2021-09-06 15:41:49 -07:00
parent ff07f9c268
commit 33c5b8b7c0
10 changed files with 49 additions and 49 deletions

View File

@@ -5012,7 +5012,7 @@ void Game::readmaingamesave(const char* savename, tinyxml2::XMLDocument& doc)
}
void Game::customloadquick(std::string savfile)
void Game::customloadquick(const std::string& savfile)
{
tinyxml2::XMLDocument doc;
tinyxml2::XMLHandle hDoc(&doc);
@@ -5541,7 +5541,7 @@ std::string Game::writemaingamesave(tinyxml2::XMLDocument& doc)
}
bool Game::customsavequick(std::string savfile)
bool Game::customsavequick(const std::string& savfile)
{
const std::string levelfile = savfile.substr(7);