Se.Cherkasov/VVVVVV
1
0
Fork 0
mirror of https://github.com/TerryCavanagh/VVVVVV.git synced 2026-01-29 17:38:16 +03:00
Code Issues Packages Projects Releases Wiki Activity

Set valid to false if size is bogus

Browse Source 
This is to prevent callers from parsing bogus sizes. If they listen to
the -1 sentinel value, at least...
This commit is contained in:
Misa
2020-08-14 01:50:41 -07:00
committed by Ethan Lee
parent 7903b8967e
commit 6991b2045d
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
desktop_version/src/BinaryBlob.cpp
View File

@@ -98,10 +98,12 @@ bool binaryBlob::unPackBinary(const char* name)
} }
if (m_headers[i].size < 1) if (m_headers[i].size < 1)
{ {
m_headers[i].valid = false;
continue; /* Must be nonzero and positive */ continue; /* Must be nonzero and positive */
} }
if ((offset + m_headers[i].size) > size) if ((offset + m_headers[i].size) > size)
{ {
m_headers[i].valid = false;
continue; /* Bogus size value */ continue; /* Bogus size value */
} }