Se.Cherkasov/VVVVVV
1
0
Fork 0
mirror of https://github.com/TerryCavanagh/VVVVVV.git synced 2026-01-29 17:38:16 +03:00
Code Issues Packages Projects Releases Wiki Activity

Explicitly declare void for all void parameter functions (#628)

Browse Source 
Apparently in C, if you have `void test();`, it's completely okay to do
`test(2);`. The function will take in the argument, but just discard it
and throw it away. It's like a trash can, and a rude one at that. If you
declare it like `void test(void);`, this is prevented.

This is not a problem in C++ - doing `void test();` and `test(2);` is
guaranteed to result in a compile error (this also means that right now,
at least in all `.cpp` files, nobody is ever calling a void parameter
function with arguments and having their arguments be thrown away).
However, we may not be using C++ in the future, so I just want to lay
down the precedent that if a function takes in no arguments, you must
explicitly declare it as such.

I would've added `-Wstrict-prototypes`, but it produces an annoying
warning message saying it doesn't work in C++ mode if you're compiling
in C++ mode. So it can be added later.
This commit is contained in:
Misa
2021-02-25 14:23:59 -08:00
committed by GitHub
parent 0e313d0d75
commit 6a3a1fe147
53 changed files with 439 additions and 439 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
desktop_version/src/Network.c
View File

@@ -26,10 +26,10 @@
#define NUM_BACKENDS (STEAM_NUM+GOG_NUM)
#define DECLARE_BACKEND(name) \
int32_t name##_init(); \
void name##_shutdown(); \
void name##_update(); \
void name##_unlockAchievement(); \
int32_t name##_init(void); \
void name##_shutdown(void); \
void name##_update(void); \
void name##_unlockAchievement(const char *name); \
int32_t name##_getAchievementProgress(const char *name); \
void name##_setAchievementProgress(const char *name, int32_t stat);
#ifdef STEAM_NETWORK
@@ -43,10 +43,10 @@ DECLARE_BACKEND(GOG)
typedef struct NetworkBackend
{
int32_t IsInit;
int32_t (*Init)();
void (*Shutdown)();
void (*Update)();
void (*UnlockAchievement)();
int32_t (*Init)(void);
void (*Shutdown)(void);
void (*Update)(void);
void (*UnlockAchievement)(const char*);
int32_t (*GetAchievementProgress)(const char*);
void (*SetAchievementProgress)(const char*, int32_t);
} NetworkBackend;
@@ -55,7 +55,7 @@ typedef struct NetworkBackend
static NetworkBackend backends[NUM_BACKENDS];
#endif
int NETWORK_init()
int NETWORK_init(void)
{
int32_t any = 0;
#define ASSIGN_BACKEND(name, index) \
@@ -83,7 +83,7 @@ int NETWORK_init()
return any;
}
void NETWORK_shutdown()
void NETWORK_shutdown(void)
{
#if NUM_BACKENDS > 0
int32_t i;
@@ -95,7 +95,7 @@ void NETWORK_shutdown()
#endif
}
void NETWORK_update()
void NETWORK_update(void)
{
#if NUM_BACKENDS > 0
int32_t i;