Se.Cherkasov/VVVVVV
1
0
Fork 0
mirror of https://github.com/TerryCavanagh/VVVVVV.git synced 2026-01-29 17:38:16 +03:00
Code Issues Packages Projects Releases Wiki Activity

Explicitly declare void for all void parameter functions (#628)

Browse Source 
Apparently in C, if you have `void test();`, it's completely okay to do
`test(2);`. The function will take in the argument, but just discard it
and throw it away. It's like a trash can, and a rude one at that. If you
declare it like `void test(void);`, this is prevented.

This is not a problem in C++ - doing `void test();` and `test(2);` is
guaranteed to result in a compile error (this also means that right now,
at least in all `.cpp` files, nobody is ever calling a void parameter
function with arguments and having their arguments be thrown away).
However, we may not be using C++ in the future, so I just want to lay
down the precedent that if a function takes in no arguments, you must
explicitly declare it as such.

I would've added `-Wstrict-prototypes`, but it produces an annoying
warning message saying it doesn't work in C++ mode if you're compiling
in C++ mode. So it can be added later.
This commit is contained in:
Misa
2021-02-25 14:23:59 -08:00
committed by GitHub
parent 0e313d0d75
commit 6a3a1fe147
53 changed files with 439 additions and 439 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
desktop_version/src/Screen.cpp
View File

@@ -17,7 +17,7 @@ extern "C"
);
}
ScreenSettings::ScreenSettings()
ScreenSettings::ScreenSettings(void)
{
windowWidth = 320;
windowHeight = 240;
@@ -93,7 +93,7 @@ void Screen::init(const ScreenSettings& settings)
ResizeScreen(settings.windowWidth, settings.windowHeight);
}
void Screen::destroy()
void Screen::destroy(void)
{
#define X(CLEANUP, POINTER) \
CLEANUP(POINTER); \
@@ -123,7 +123,7 @@ void Screen::GetSettings(ScreenSettings* settings)
settings->badSignal = badSignalEffect;
}
void Screen::LoadIcon()
void Screen::LoadIcon(void)
{
unsigned char *fileIn = NULL;
size_t length = 0;
@@ -212,7 +212,7 @@ void Screen::ResizeScreen(int x, int y)
SDL_ShowWindow(m_window);
}
void Screen::ResizeToNearestMultiple()
void Screen::ResizeToNearestMultiple(void)
{
int w, h;
GetWindowSize(&w, &h);
@@ -297,12 +297,12 @@ void Screen::UpdateScreen(SDL_Surface* buffer, SDL_Rect* rect )
}
const SDL_PixelFormat* Screen::GetFormat()
const SDL_PixelFormat* Screen::GetFormat(void)
{
return m_screen->format;
}
void Screen::FlipScreen()
void Screen::FlipScreen(void)
{
SDL_UpdateTexture(
m_screenTexture,
@@ -321,19 +321,19 @@ void Screen::FlipScreen()
SDL_FillRect(m_screen, NULL, 0x00000000);
}
void Screen::toggleFullScreen()
void Screen::toggleFullScreen(void)
{
isWindowed = !isWindowed;
ResizeScreen(-1, -1);
}
void Screen::toggleStretchMode()
void Screen::toggleStretchMode(void)
{
stretchMode = (stretchMode + 1) % 3;
ResizeScreen(-1, -1);
}
void Screen::toggleLinearFilter()
void Screen::toggleLinearFilter(void)
{
isFiltered = !isFiltered;
SDL_SetHintWithPriority(
@@ -351,7 +351,7 @@ void Screen::toggleLinearFilter()
);
}
void Screen::resetRendererWorkaround()
void Screen::resetRendererWorkaround(void)
{
SDL_SetHintWithPriority(
SDL_HINT_RENDER_VSYNC,