Se.Cherkasov/VVVVVV
1
0
Fork 0
mirror of https://github.com/TerryCavanagh/VVVVVV.git synced 2026-01-30 01:48:15 +03:00
Code Issues Packages Projects Releases Wiki Activity

Explicitly declare void for all void parameter functions (#628)

Browse Source 
Apparently in C, if you have `void test();`, it's completely okay to do
`test(2);`. The function will take in the argument, but just discard it
and throw it away. It's like a trash can, and a rude one at that. If you
declare it like `void test(void);`, this is prevented.

This is not a problem in C++ - doing `void test();` and `test(2);` is
guaranteed to result in a compile error (this also means that right now,
at least in all `.cpp` files, nobody is ever calling a void parameter
function with arguments and having their arguments be thrown away).
However, we may not be using C++ in the future, so I just want to lay
down the precedent that if a function takes in no arguments, you must
explicitly declare it as such.

I would've added `-Wstrict-prototypes`, but it produces an annoying
warning message saying it doesn't work in C++ mode if you're compiling
in C++ mode. So it can be added later.
This commit is contained in:
Misa
2021-02-25 14:23:59 -08:00
committed by GitHub
parent 0e313d0d75
commit 6a3a1fe147
53 changed files with 439 additions and 439 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
desktop_version/src/Textbox.cpp
View File

@@ -2,7 +2,7 @@
#include <utf8/unchecked.h>
textboxclass::textboxclass()
textboxclass::textboxclass(void)
{
x = 0;
y = 0;
@@ -29,20 +29,20 @@ textboxclass::textboxclass()
textrect.h = 0;
}
void textboxclass::centerx()
void textboxclass::centerx(void)
{
resize();
xp = 160 - (w / 2);
resize();
}
void textboxclass::centery()
void textboxclass::centery(void)
{
resize();
yp = 120 - (h / 2);
resize();
}
void textboxclass::adjust()
void textboxclass::adjust(void)
{
resize();
if (xp < 10) xp = 10;
@@ -70,7 +70,7 @@ void textboxclass::setcol(int rr, int gg, int bb)
b = bb;
}
void textboxclass::update()
void textboxclass::update(void)
{
prev_tl = tl;
if (tm == 0)
@@ -98,19 +98,19 @@ void textboxclass::update()
}
}
void textboxclass::remove()
void textboxclass::remove(void)
{
tm = 2;
tl = 1.0f; //Remove mode
}
void textboxclass::removefast()
void textboxclass::removefast(void)
{
tm = 2;
tl = 0.4f; //Remove mode
}
void textboxclass::resize()
void textboxclass::resize(void)
{
//Set the width and height to the correct sizes
max = 0;