Se.Cherkasov/VVVVVV
1
0
Fork 0
mirror of https://github.com/TerryCavanagh/VVVVVV.git synced 2026-01-29 17:38:16 +03:00
Code Issues Packages Projects Releases Wiki Activity

Explicitly declare void for all void parameter functions (#628)

Browse Source 
Apparently in C, if you have `void test();`, it's completely okay to do
`test(2);`. The function will take in the argument, but just discard it
and throw it away. It's like a trash can, and a rude one at that. If you
declare it like `void test(void);`, this is prevented.

This is not a problem in C++ - doing `void test();` and `test(2);` is
guaranteed to result in a compile error (this also means that right now,
at least in all `.cpp` files, nobody is ever calling a void parameter
function with arguments and having their arguments be thrown away).
However, we may not be using C++ in the future, so I just want to lay
down the precedent that if a function takes in no arguments, you must
explicitly declare it as such.

I would've added `-Wstrict-prototypes`, but it produces an annoying
warning message saying it doesn't work in C++ mode if you're compiling
in C++ mode. So it can be added later.
This commit is contained in:
Misa
2021-02-25 14:23:59 -08:00
committed by GitHub
parent 0e313d0d75
commit 6a3a1fe147
53 changed files with 439 additions and 439 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
desktop_version/src/Tower.cpp
View File

@@ -3,7 +3,7 @@
#include "MakeAndPlay.h"
#include "UtilityClass.h"
towerclass::towerclass()
towerclass::towerclass(void)
{
minitowermode = false;
//We init the lookup table:
@@ -91,7 +91,7 @@ int towerclass::miniat(int xp, int yp, int yoff)
return 0;
}
void towerclass::loadminitower1()
void towerclass::loadminitower1(void)
{
//Loads the first minitower into the array.
#if !defined(MAKEANDPLAY)
@@ -202,7 +202,7 @@ void towerclass::loadminitower1()
#endif
}
void towerclass::loadminitower2()
void towerclass::loadminitower2(void)
{
#if !defined(MAKEANDPLAY)
static const short tmap[] = {
@@ -313,7 +313,7 @@ void towerclass::loadminitower2()
}
void towerclass::loadbackground()
void towerclass::loadbackground(void)
{
//Loads the background into the array.
static const short tmap[] = {
@@ -441,7 +441,7 @@ void towerclass::loadbackground()
SDL_memcpy(back, tmap, sizeof(back));
}
void towerclass::loadmap()
void towerclass::loadmap(void)
{
//Loads the map into the array.
#if !defined(MAKEANDPLAY)