Se.Cherkasov/VVVVVV
1
0
Fork 0
mirror of https://github.com/TerryCavanagh/VVVVVV.git synced 2026-01-30 01:48:15 +03:00
Code Issues Packages Projects Releases Wiki Activity

Explicitly declare void for all void parameter functions (#628)

Browse Source 
Apparently in C, if you have `void test();`, it's completely okay to do
`test(2);`. The function will take in the argument, but just discard it
and throw it away. It's like a trash can, and a rude one at that. If you
declare it like `void test(void);`, this is prevented.

This is not a problem in C++ - doing `void test();` and `test(2);` is
guaranteed to result in a compile error (this also means that right now,
at least in all `.cpp` files, nobody is ever calling a void parameter
function with arguments and having their arguments be thrown away).
However, we may not be using C++ in the future, so I just want to lay
down the precedent that if a function takes in no arguments, you must
explicitly declare it as such.

I would've added `-Wstrict-prototypes`, but it produces an annoying
warning message saying it doesn't work in C++ mode if you're compiling
in C++ mode. So it can be added later.
This commit is contained in:
Misa
2021-02-25 14:23:59 -08:00
committed by GitHub
parent 0e313d0d75
commit 6a3a1fe147
53 changed files with 439 additions and 439 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
desktop_version/src/main.cpp
View File

@@ -73,10 +73,10 @@ static inline Uint32 get_framerate(const int slowdown)
return 34;
}
static void inline deltaloop();
static void inline fixedloop();
static void inline deltaloop(void);
static void inline fixedloop(void);
static void cleanup();
static void cleanup(void);
int main(int argc, char *argv[])
{
@@ -360,7 +360,7 @@ int main(int argc, char *argv[])
return 0;
}
static void cleanup()
static void cleanup(void)
{
/* Order matters! */
game.savestatsandsettings();
@@ -380,7 +380,7 @@ void VVV_exit(const int exit_code)
exit(exit_code);
}
static void inline deltaloop()
static void inline deltaloop(void)
{
//timestep limit to 30
const float rawdeltatime = static_cast<float>(time_ - timePrev);
@@ -448,7 +448,7 @@ static void inline deltaloop()
}
}
static void inline fixedloop()
static void inline fixedloop(void)
{
// Update network per frame.
NETWORK_update();