Se.Cherkasov/VVVVVV
1
0
Fork 0
mirror of https://github.com/TerryCavanagh/VVVVVV.git synced 2026-01-30 01:48:15 +03:00
Code Issues Packages Projects Releases Wiki Activity

Ensure that all member attributes are initialized

Browse Source 
I ran the game through cppcheck and it spat out a bunch of member
attributes that weren't being initialized. So I initialized them.

In the previous version of this commit, I added constructors to
GraphicsResources, otherlevelclass, labclass, warpclass, and finalclass,
but flibit says this changes the code flow enough that it's risky to
merge before 2.4, so I got rid of those constructors, too.
This commit is contained in:
Misa
2020-07-06 13:04:34 -07:00
committed by Ethan Lee
parent 3b6867243b
commit 7703b2c1c2
9 changed files with 88 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
desktop_version/src/GraphicsResources.cpp
View File

@@ -109,26 +109,31 @@ void GraphicsResources::init(void)
void GraphicsResources::destroy(void)
{
SDL_FreeSurface(im_tiles);
SDL_FreeSurface(im_tiles2);
SDL_FreeSurface(im_tiles3);
SDL_FreeSurface(im_entcolours);
SDL_FreeSurface(im_sprites);
SDL_FreeSurface(im_flipsprites);
SDL_FreeSurface(im_bfont);
SDL_FreeSurface(im_teleporter);
#define CLEAR(img) \
SDL_FreeSurface(img); \
img = NULL;
SDL_FreeSurface(im_image0);
SDL_FreeSurface(im_image1);
SDL_FreeSurface(im_image2);
SDL_FreeSurface(im_image3);
SDL_FreeSurface(im_image4);
SDL_FreeSurface(im_image5);
SDL_FreeSurface(im_image6);
SDL_FreeSurface(im_image7);
SDL_FreeSurface(im_image8);
SDL_FreeSurface(im_image9);
SDL_FreeSurface(im_image10);
SDL_FreeSurface(im_image11);
SDL_FreeSurface(im_image12);
CLEAR(im_tiles);
CLEAR(im_tiles2);
CLEAR(im_tiles3);
CLEAR(im_entcolours);
CLEAR(im_sprites);
CLEAR(im_flipsprites);
CLEAR(im_bfont);
CLEAR(im_teleporter);
CLEAR(im_image0);
CLEAR(im_image1);
CLEAR(im_image2);
CLEAR(im_image3);
CLEAR(im_image4);
CLEAR(im_image5);
CLEAR(im_image6);
CLEAR(im_image7);
CLEAR(im_image8);
CLEAR(im_image9);
CLEAR(im_image10);
CLEAR(im_image11);
CLEAR(im_image12);
#undef CLEAR
}