From aa2cf3ab4b0d6b5ca84a3c220e8fa7a2f5f2601e Mon Sep 17 00:00:00 2001 From: Misa Date: Thu, 29 Dec 2022 16:13:54 -0800 Subject: [PATCH] Use _SDL_HAS_BUILTIN I think this is because if you both check that __has_builtin is defined and use it in the same 'if' preprocessor statement, it can error because there's no equivalent to short-circuiting in preprocessor statements. _SDL_HAS_BUILTIN should be safer. --- desktop_version/src/Unreachable.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/desktop_version/src/Unreachable.h b/desktop_version/src/Unreachable.h index d37db95d..28b18868 100644 --- a/desktop_version/src/Unreachable.h +++ b/desktop_version/src/Unreachable.h @@ -7,7 +7,7 @@ SDL_NORETURN SDL_INLINE void VVV_unreachable(void) { /* __builtin_unreachable() and __assume(0) execute undefined behavior. * Otherwise, a noreturn function returning is also undefined behavior. */ -#if defined(__has_builtin) && __has_builtin(__builtin_unreachable) +#if _SDL_HAS_BUILTIN(__builtin_unreachable) __builtin_unreachable(); #elif defined(_MSC_VER) __assume(0);