From bd71fb8a689d8f5479461501057be1111a92ccff Mon Sep 17 00:00:00 2001 From: Ethan Lee Date: Sun, 14 Jun 2020 22:43:58 -0400 Subject: [PATCH] Disallow negative size values in BinaryBlob --- desktop_version/src/BinaryBlob.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/desktop_version/src/BinaryBlob.cpp b/desktop_version/src/BinaryBlob.cpp index 8d25ec25..76eea13a 100644 --- a/desktop_version/src/BinaryBlob.cpp +++ b/desktop_version/src/BinaryBlob.cpp @@ -105,6 +105,10 @@ bool binaryBlob::unPackBinary(const char* name) { continue; /* Must be EXACTLY 1 or 0 */ } + if (size < 1) + { + continue; /* Must be nonzero and positive */ + } if ((offset + m_headers[i].size) > size) { continue; /* Bogus size value */