Guard all cases obj.getplayer() is used unchecked

Browse Source

obj.getplayer() can return -1, which can cause out-of-bounds indexing of
obj.entities, which is really bad. This was by far the most changes, as
obj.getplayer() is the most used entity-getting function that returns
-1, as well as the most-used function whose sentinel value goes
unchecked.

To deal with the usage of obj.getplayer() in mapclass::warpto(), I just
added general bounds checks inside that function instead of changing all
the callers.

...

This commit is contained in:

Misa

2020-06-12 20:36:08 -07:00

committed by Ethan Lee

parent 08e47e839f

commit beab344267

7 changed files with 784 additions and 408 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

706

desktop_version/src/Game.cpp

File diff suppressed because it is too large Load Diff