2.3.3

This fixes all the headaches about map.extrarow having to be the correct
value and which way it should be and whatnot. The latest headache was
the detection that prevent user-initiated menu animations while an
animation was already happening being tripped because
graphics.menuoffset would be 230 (due to closing the menu while being in
a room without a room name), but then going to a room with a room name
would check for 240 instead, and 230 is less than 240. (The numbers are
the wrong way round because I got the ternaries the wrong way round, but
even if the numbers are the correct way round, the bug would still
happen, but it would just be reversed.)

So instead, I've just made it 240 for both. This doesn't change the
duration of the menu animation (because the animation moves in
increments of 25, and 230 / 25 == 240 / 25 under integer division). It
might change the animation slightly, but it was already inconsistent
anyway because map.extrarow was always set to be 1 in custom levels, and
I legitimately would not be able to tell the difference without
recording the animations and nitpicking it frame-by-frame.

Fixes #841.

desktop_version/src/Game.cpp

@@ -6896,7 +6896,7 @@ void Game::mapmenuchange(const int newgamestate, const bool user_initiated)
 {
     if (user_initiated
     && graphics.menuoffset > 0
-    && graphics.menuoffset < (map.extrarow ? 230 : 240))
+    && graphics.menuoffset < 240)
     {
         return;
     }

desktop_version/src/Music.cpp

@@ -202,9 +202,6 @@ void musicclass::play(int t)
 		return;
 	}
 
-	m_doFadeInVol = false;
-	m_doFadeOutVol = false;
-
 	if (currentsong == 0 || currentsong == 7 || (!map.custommode && (currentsong == 0+num_mmmmmm_tracks || currentsong == 7+num_mmmmmm_tracks)))
 	{
 		// Level Complete theme, no fade in or repeat
@@ -214,6 +211,8 @@ void musicclass::play(int t)
 		}
 		else
 		{
+			m_doFadeInVol = false;
+			m_doFadeOutVol = false;
 			musicVolume = MIX_MAX_VOLUME;
 			Mix_VolumeMusic(musicVolume);
 		}
@@ -242,6 +241,8 @@ void musicclass::play(int t)
 		}
 		else
 		{
+			m_doFadeInVol = false;
+			m_doFadeOutVol = false;
 			fadeMusicVolumeIn(3000);
 		}
 	}

desktop_version/src/Render.cpp

@@ -159,7 +159,7 @@ static void menurender(void)
 #ifdef INTERIM_COMMIT
         graphics.Print( 310 - (SDL_arraysize(INTERIM_COMMIT) - 1) * 8, 220, INTERIM_COMMIT, tr/2, tg/2, tb/2);
 #endif
-        graphics.Print( 310 - (6*8), 230, "v2.3.2", tr/2, tg/2, tb/2);
+        graphics.Print( 310 - (6*8), 230, "v2.3.3", tr/2, tg/2, tb/2);
 
         if(music.mmmmmm){
             graphics.Print( 10, 230, "[MMMMMM Mod Installed]", tr/2, tg/2, tb/2);

desktop_version/src/RenderFixed.cpp

@@ -205,7 +205,7 @@ void maprenderfixed(void)
         || !script.running)
         {
             graphics.menuoffset += 25;
-            int threshold = map.extrarow ? 230 : 240;
+            int threshold = 240;
             if (graphics.menuoffset >= threshold)
             {
                 graphics.menuoffset = threshold;