Se.Cherkasov/VVVVVV
1
0
Fork 0
mirror of https://github.com/TerryCavanagh/VVVVVV.git synced 2026-07-27 17:41:49 +03:00
Code Issues Packages Projects Releases Wiki Activity
Files
6810c5fa8ce063c97f050f56943940329baad1e7
VVVVVV/desktop_version/src
T
History
NyakoFox 6810c5fa8c Fix #1223 (analogue mode segfault) 
When `SDL_RenderReadPixels` fails for some reason, the game tries to
free the temporary source surface it creates. Unfortunately, it never
sets it to `NULL` after, so the next time the game tries to render the
filter, it'll try to work with a memory region that was already freed.

To fix this, I just replaced `SDL_FreeSurface(*src);` with
`VVV_freefunc(SDL_FreeSurface, *src);` which is a helper macro which
sets the pointer to NULL after freeing.

Now, there's a new issue -- since the temporary buffer is now NULL,
next frame we'll try to remake it! So I've introduced a static bool
which disables the filter entirely if `SDL_RenderReadPixels` fails.
Without this, it'd create and destroy a surface every frame, which
could lead to slowdown. (Not as slow as the filter when it DOES work,
but still...)

I also added a line which frees the second temporary surface... it's
weird that was missing in the first place, but I think reimplementing
analogue mode was one of the last things I did for the renderer
rewrite anyways.

Resolves #1223.
2025-04-29 20:54:11 -04:00
..
ActionSets.h
Add controller button layout mappings
2023-03-21 19:59:48 -07:00
Alloc.h
Replace all free calls with VVV_free[func]
2022-11-30 22:50:08 -08:00
BinaryBlob.cpp
Replace all free calls with VVV_free[func]
2022-11-30 22:50:08 -08:00
BinaryBlob.h
Use fixed-size int types for resourceheader
2021-09-23 22:21:49 -07:00
BlockV.cpp
Make activity zone prompts loc::gettext'ed at display time
2023-09-20 16:20:24 -07:00
BlockV.h
Make activity zone prompts loc::gettext'ed at display time
2023-09-20 16:20:24 -07:00
ButtonGlyphs.cpp
iOS port (for desktop_version) (#1137)
2024-11-15 20:33:10 -05:00
ButtonGlyphs.h
Add "type:" override check for virtual Sony gamepads.
2023-12-01 12:08:26 -05:00
Constants.h
Fix SCREEN_HEIGHT_PIXELS being wrong constant
2021-10-01 09:35:28 -07:00
Credits.h
CONTRIBUTORS.txt: leo60228 -> leo vriska
2024-05-21 20:57:19 -07:00
CustomLevels.cpp
Move saving outside of MetaData (oops!)
2025-04-12 16:43:50 -04:00
CustomLevels.h
Add player colour as a level property
2025-04-12 16:43:50 -04:00
CWrappers.cpp
Upscale screenshots 2x
2024-01-09 15:48:41 -08:00
CWrappers.h
Upscale screenshots 2x
2024-01-09 15:48:41 -08:00
DeferCallbacks.c
Add deferred callbacks to game loop
2021-03-21 02:55:42 -04:00
DeferCallbacks.h
Add deferred callbacks to game loop
2021-03-21 02:55:42 -04:00
Editor.cpp
Add player colour as a level property
2025-04-12 16:43:50 -04:00
Editor.h
Revert "Translate editor notes on-the-fly"
2024-02-02 19:13:59 -08:00
Ent.cpp
Replace colour IDs with an enum
2025-04-21 20:09:57 -04:00
Ent.h
Replace colour IDs with an enum
2025-04-21 20:09:57 -04:00
Entity.cpp
Fix "invalid" activity zones not spawning
2025-04-28 08:04:51 -04:00
Entity.h
Replace colour IDs with an enum
2025-04-21 20:09:57 -04:00
Enums.h
Remove unused game-gamestates
2021-12-18 00:01:32 -08:00
Exit.h
Use SDL_NORETURN
2021-09-27 10:32:23 -07:00
FileSystemUtils.cpp
iOS port (for desktop_version) (#1137)
2024-11-15 20:33:10 -05:00
FileSystemUtils.h
Add support for internal screenshots
2024-01-09 15:48:41 -08:00
Finalclass.cpp
Strip out old special roomname system
2023-03-02 22:58:12 -08:00
Finalclass.h
Indicate what special roomnames are in the levels
2022-12-31 20:04:56 -08:00
Font.cpp
Properly fix setfont/setrtl in between text boxes
2024-01-23 15:33:38 -08:00
Font.h
Properly fix setfont/setrtl in between text boxes
2024-01-23 15:33:38 -08:00
FontBidi.cpp
Don't pass newline characters to bidi algorithm
2024-01-08 19:17:44 -08:00
FontBidi.h
Add RTL level property and print flag
2024-01-08 19:17:44 -08:00
Game.cpp
Replace colour IDs with an enum
2025-04-21 20:09:57 -04:00
Game.h
Abstract checkpoint saving to its own function
2024-09-27 17:14:57 -07:00
GlitchrunnerMode.c
Split glitchrunner mode into multiple versions
2021-08-05 13:35:21 -04:00
GlitchrunnerMode.h
Split glitchrunner mode into multiple versions
2021-08-05 13:35:21 -04:00
GOGNetwork.c
Axe NETWORK_[set/get]AchievementProgress()
2021-09-19 21:49:54 -07:00
Graphics.cpp
Replace colour IDs with an enum
2025-04-21 20:09:57 -04:00
Graphics.h
Replace colour IDs with an enum
2025-04-21 20:09:57 -04:00
GraphicsResources.cpp
Region system PR review changes
2024-11-03 21:54:44 -08:00
GraphicsResources.h
Place GraphicsResources functions in header file
2024-01-09 16:03:05 -08:00
GraphicsUtil.cpp
Fix #1223 (analogue mode segfault)
2025-04-29 20:54:11 -04:00
GraphicsUtil.h
Upscale screenshots 2x
2024-01-09 15:48:41 -08:00
IMERender.cpp
Tweak IME selection background left bound
2024-08-06 18:16:46 -07:00
IMERender.h
Add IME text rendering
2024-08-02 22:25:00 -07:00
Input.cpp
Replace colour IDs with an enum
2025-04-21 20:09:57 -04:00
Input.h
Explicitly declare void for all void parameter functions (#628)
2021-02-25 17:23:59 -05:00
InterimVersion.h
Use PR_RIGHT for interim version info in main menu
2023-02-13 23:27:00 -08:00
InterimVersion.in.c
Use PR_RIGHT for interim version info in main menu
2023-02-13 23:27:00 -08:00
KeyPoll.cpp
Add selection background to IME rendering
2024-08-02 22:25:00 -07:00
KeyPoll.h
Add selection background to IME rendering
2024-08-02 22:25:00 -07:00
Labclass.cpp
Add level exploring menu for translators
2022-12-31 20:04:56 -08:00
Labclass.h
Indicate what special roomnames are in the levels
2022-12-31 20:04:56 -08:00
LevelDebugger.cpp
Convert entity types to an enum (#1007)
2024-11-17 11:45:57 -05:00
LevelDebugger.h
Fix moving entities flashing in over 30fps mode
2023-11-19 17:34:23 -08:00
Localization.cpp
Make language screen show up once more
2024-02-08 10:28:27 -08:00
Localization.h
Make language screen show up once more
2024-02-08 10:28:27 -08:00
LocalizationMaint.cpp
Add RTL level property and print flag
2024-01-08 19:17:44 -08:00
LocalizationMaint.h
Add cutscene test menu
2022-12-31 20:04:56 -08:00
LocalizationStorage.cpp
Add RTL level property and print flag
2024-01-08 19:17:44 -08:00
LocalizationStorage.h
Add a system for selecting between wordy/wordy2
2024-01-06 14:11:40 -08:00
lodepng_wrapper.c
Migrate LodePNG to submodule
2022-03-13 23:50:37 -07:00
Logic.cpp
Convert entity types to an enum (#1007)
2024-11-17 11:45:57 -05:00
Logic.h
Explicitly declare void for all void parameter functions (#628)
2021-02-25 17:23:59 -05:00
main.cpp
iOS port (for desktop_version) (#1137)
2024-11-15 20:33:10 -05:00
MakeAndPlay.h
Use multiline comments in C files
2021-04-17 00:50:04 -04:00
Map.cpp
Replace colour IDs with an enum
2025-04-21 20:09:57 -04:00
Map.h
Region system PR review changes
2024-11-03 21:54:44 -08:00
Maths.h
Use SDL_Point instead of rolling our own point struct
2023-01-28 23:32:14 -08:00
Music.cpp
musicVolume -> controlVolume for clarity
2024-12-17 09:52:06 -05:00
Music.h
musicVolume -> controlVolume for clarity
2024-12-17 09:52:06 -05:00
Network.c
Axe NETWORK_[set/get]AchievementProgress()
2021-09-19 21:49:54 -07:00
Network.h
Explicitly declare void for all void parameter functions (#628)
2021-02-25 17:23:59 -05:00
Otherlevel.cpp
Replace colour IDs with an enum
2025-04-21 20:09:57 -04:00
Otherlevel.h
Indicate what special roomnames are in the levels
2022-12-31 20:04:56 -08:00
preloader.cpp
XFLIP LOADING... screen
2024-01-08 19:17:44 -08:00
preloader.h
Explicitly declare void for all void parameter functions (#628)
2021-02-25 17:23:59 -05:00
ReleaseVersion.h
Bump version to v2.5
2024-08-27 15:13:24 -07:00
Render.cpp
Fix the campaign trinket count missing from stats
2025-04-29 20:53:05 -04:00
Render.h
Explicitly declare void for all void parameter functions (#628)
2021-02-25 17:23:59 -05:00
RenderFixed.cpp
Indicate modes when loading in to gameplay
2024-01-08 20:01:27 -08:00
RenderFixed.h
Show skip prompt during credits and ending picture
2023-06-05 17:57:23 -07:00
RoomnameTranslator.cpp
Move all other text boxes to new system
2024-02-02 18:57:24 -08:00
RoomnameTranslator.h
Migrate more prints to font::, determine font for most textboxes
2023-02-13 23:27:00 -08:00
Screen.cpp
iOS port (for desktop_version) (#1137)
2024-11-15 20:33:10 -05:00
Screen.h
Implement scaling modes manually
2024-02-03 18:11:11 -08:00
ScreenSettings.h
Store display index of window to settings
2023-03-21 00:23:42 -07:00
Script.cpp
Replace colour IDs with an enum
2025-04-21 20:09:57 -04:00
Script.h
position(force) -> position(absolute)
2024-11-07 09:53:45 -08:00
Scripts.cpp
Fix "he'd be a a big help" typo
2023-11-30 08:38:40 -08:00
SDL_uikit_main.c
iOS port (for desktop_version) (#1137)
2024-11-15 20:33:10 -05:00
Spacestation2.cpp
Use enums for time trial indexes
2023-06-05 17:57:23 -07:00
Spacestation2.h
Indicate what special roomnames are in the levels
2022-12-31 20:04:56 -08:00
SteamNetwork.c
Upscale screenshots 2x
2024-01-09 15:48:41 -08:00
TerminalScripts.cpp
Add textcase(n) commands to scripts
2022-12-31 20:04:56 -08:00
Textbook.c
VS2010 buildfixes.
2023-11-27 12:09:42 -05:00
Textbook.h
Add Textbook
2022-12-31 20:04:56 -08:00
Textbox.cpp
position(force) -> position(absolute)
2024-11-07 09:53:45 -08:00
Textbox.h
position(force) -> position(absolute)
2024-11-07 09:53:45 -08:00
ThirdPartyDeps.c
Replace all free calls with VVV_free[func]
2022-11-30 22:50:08 -08:00
Tower.cpp
Add POS_MOD macro and use for all positive modulos
2021-09-24 17:48:15 -07:00
Tower.h
Remove vmult lookup tables
2021-09-24 16:37:27 -07:00
TowerBG.h
Move from surfaces to the SDL render system
2023-01-28 14:36:28 -08:00
Unreachable.h
Use _SDL_HAS_BUILTIN
2022-12-29 16:13:54 -08:00
Unused.h
Factor out UNUSED macro to header file
2021-05-25 15:23:34 -04:00
UTF8.c
Add UTF8.c
2023-02-27 23:00:41 -08:00
UTF8.h
Add UTF8.c
2023-02-27 23:00:41 -08:00
UtilityClass.cpp
Add a system for selecting between wordy/wordy2
2024-01-06 14:11:40 -08:00
UtilityClass.h
Add a system for selecting between wordy/wordy2
2024-01-06 14:11:40 -08:00
VFormat.c
Add a system for selecting between wordy/wordy2
2024-01-06 14:11:40 -08:00
VFormat.h
Add support for button glyph display
2023-03-21 19:59:48 -07:00
Vlogging.c
iOS port (for desktop_version) (#1137)
2024-11-15 20:33:10 -05:00
Vlogging.h
Add -console option on Windows
2022-11-14 19:40:23 -08:00
WarpClass.cpp
Add level exploring menu for translators
2022-12-31 20:04:56 -08:00
WarpClass.h
Indicate what special roomnames are in the levels
2022-12-31 20:04:56 -08:00
XMLUtils.cpp
Move all settings to settings.vvv
2020-11-04 12:06:57 -05:00
XMLUtils.h
Add localization "foundation" (many code changes)
2022-12-31 20:04:56 -08:00
Xoshiro.c
VS2010 buildfixes.
2023-11-27 12:09:42 -05:00
Xoshiro.h
Replace Gravitron RNG with seeded Xoshiro
2021-08-27 12:28:35 -07:00